From: Katerina Kubecova <katerina.kubecova@nic.cz>
Date: Wed, 23 Apr 2025 11:50:53 +0000 (+0200)
Subject: Table export: Drop redundant not-seen old route nullification
X-Git-Tag: v3.1.1~23^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=682d83eaa37893dcaf7527c326fd4379ddff4d37;p=thirdparty%2Fbird.git

Table export: Drop redundant not-seen old route nullification

This piece of code was accidentally reintroduced in
da838bca052b3b1e5533e2900299b4140e2d5d13 CLI: fix channel stats display

and not only is obviously not relevant to that commit, it is also
obviously wrong because exactly the same nullification has been pushed
later to rt_notify_basic().
---

diff --git a/nest/rt-table.c b/nest/rt-table.c
index 5b438aa7f..f1fc2e4f0 100644
--- a/nest/rt-table.c
+++ b/nest/rt-table.c
@@ -1580,10 +1580,6 @@ channel_notify_basic(void *_channel)
 	      rt_export_processed(&c->out_req, rpe->it.seq);
 	    }
 
-          /* Have we exported the old route? */
-          if (old && !bmap_test(&c->export_accepted_map, old->id))
-            old = NULL;
-
 	  /* Ignore invalid routes */
 	  if (!rte_is_valid(new))
 	    new = NULL;