From: James Jones <jejones3141@gmail.com>
Date: Thu, 5 May 2022 12:52:12 +0000 (-0500)
Subject: Remove needless check for FR_TYPE_NULL (CID #1503975) (#4488)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=682e59ac78e4f24b9b8770cacb7b68534df2f23b;p=thirdparty%2Ffreeradius-server.git

Remove needless check for FR_TYPE_NULL (CID #1503975) (#4488)
---

diff --git a/src/lib/server/tmpl_tokenize.c b/src/lib/server/tmpl_tokenize.c
index d1799033140..9cdc6b577a5 100644
--- a/src/lib/server/tmpl_tokenize.c
+++ b/src/lib/server/tmpl_tokenize.c
@@ -3171,11 +3171,8 @@ int tmpl_cast_set(tmpl_t *vpt, fr_type_t dst_type)
 	 *	By default, tmpl types cannot be cast to anything.
 	 */
 	default:
-		if (dst_type != FR_TYPE_NULL) {
-			fr_strerror_const("Cannot use cast here.");
-			return -1;
-		}
-		break;
+		fr_strerror_const("Cannot use cast here.");
+		return -1;
 
 	/*
 	 *	These tmpl types are effectively of data type