From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 28 Nov 2018 16:27:46 +0000 (-0500)
Subject: Add a test harness for MySQL connect args
X-Git-Tag: rel_1_3_0b2~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6837e875a3367b466e2ce04ca16c7bff8fa5c575;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Add a test harness for MySQL connect args

This is to assist with #4381.

Change-Id: I5ebfc0da906a13edc4fb3f0ca7ab2d843d43bb00
---

diff --git a/test/dialect/mysql/test_dialect.py b/test/dialect/mysql/test_dialect.py
index d72418ba3b..d06b0ddd40 100644
--- a/test/dialect/mysql/test_dialect.py
+++ b/test/dialect/mysql/test_dialect.py
@@ -44,6 +44,28 @@ class DialectTest(fixtures.TestBase):
             }
         )
 
+    def test_normal_arguments_mysqldb(self):
+        from sqlalchemy.dialects.mysql import mysqldb
+        dialect = mysqldb.dialect()
+        self._test_normal_arguments(dialect)
+
+    def _test_normal_arguments(self, dialect):
+        for kwarg, value in [
+            ('compress', True),
+            ('connect_timeout', 30),
+            ('read_timeout', 30),
+            ('client_flag', 1234),
+            ('local_infile', 1234),
+            ('use_unicode', False),
+            ('charset', 'hello')
+        ]:
+            connect_args = dialect.create_connect_args(
+                make_url("mysql://scott:tiger@localhost:3306/test"
+                         "?%s=%s" % (kwarg, value))
+            )
+
+            eq_(connect_args[1][kwarg], value)
+
     def test_mysqlconnector_buffered_arg(self):
         from sqlalchemy.dialects.mysql import mysqlconnector
         dialect = mysqlconnector.dialect()