From: Emma Foley <elfiesmelfie@users.noreply.github.com>
Date: Tue, 15 Feb 2022 11:41:38 +0000 (+0000)
Subject: [gha] Add a test log when the tests fail (#3971)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68390d002a116460798543ee6ebea04b042320f7;p=thirdparty%2Fcollectd.git

[gha] Add a test log when the tests fail (#3971)

* [ci][gha] Add a test log when the tests fail

* [ci][cirrus] Update CI to provide test logs on failure

Co-authored-by: Matthias Runge <mrunge@redhat.com>
---

diff --git a/.cirrus.yml b/.cirrus.yml
index bde86c351..8df130b66 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -61,7 +61,7 @@ debian_default_toolchain_task:
   build_script:
     - make -j2 -sk
   tests_script:
-    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check
+    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check || cat ./test-suite.log || false
     - /checks/check-built-plugins.sh
 
 ###
@@ -92,7 +92,7 @@ redhat_default_toolchain_task:
   build_script:
     - make -j2 -sk
   tests_script:
-    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check
+    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check || cat ./test-suite.log || false
     - /checks/check-built-plugins.sh
 
 
@@ -124,7 +124,7 @@ non_standard_toolchains_task:
       build_script:
         - make -j2 -sk
       tests_script:
-        - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check
+        - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check || cat ./test-suite.log || false
 
     # build against libstatgrab, should always pass
     - env:
@@ -189,7 +189,7 @@ non_standard_toolchains_task:
       build_script:
         - make -j2 -sk
       tests_script:
-        - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check
+        - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check || cat ./test-suite.log || false
 
 ###
 # Build using a range of compilers, available in debian/unstable. NB: might
@@ -221,4 +221,4 @@ bleeding_edge_compilers_task:
   build_script:
     - make -j2 -sk
   tests_script:
-    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check
+    - VALGRIND_OPTS="--errors-for-leak-kinds=definite" make -j2 -sk check || cat ./test-suite.log || false
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index cf6d0baad..f7430769f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -55,6 +55,9 @@ jobs:
     - name: make check
       continue-on-error: true
       run: make check
+    - name: Dump test logs
+      run: |
+          cat ./test-suite.log || true
     - name: install bzip2
       continue-on-error: true
       run: |
@@ -104,6 +107,9 @@ jobs:
       # Make check is failing on a few newer distros, temporarily mark it as optional until that is resolved 
       continue-on-error: true
       run: make check
+    - name: Dump test logs
+      run: |
+          cat ./test-suite.log || true
     - name: install bzip2
       continue-on-error: true
       run: |