From: Alejandro Colomar <colomar.6.4.3@gmail.com>
Date: Sat, 5 Sep 2020 15:15:00 +0000 (+0200)
Subject: bsearch.3: Fix intermediate type and remove unneeded casts
X-Git-Tag: man-pages-5.09~431
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=684130db5c612fb91e348d87efd0c353c6ef2cfe;p=thirdparty%2Fman-pages.git

bsearch.3: Fix intermediate type and remove unneeded casts

Casting `const void *` to `struct mi *` should result in a warning if
done implicitly.  The explicit cast was probably silencing that warning.
`const` can and should be kept.
Now, casting `const void *` to `const struct mi *` is done implicitly.

Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
---

diff --git a/man3/bsearch.3 b/man3/bsearch.3
index 6dfd5158f3..9d4f76da53 100644
--- a/man3/bsearch.3
+++ b/man3/bsearch.3
@@ -114,8 +114,8 @@ struct mi {
 static int
 compmi(const void *m1, const void *m2)
 {
-    struct mi *mi1 = (struct mi *) m1;
-    struct mi *mi2 = (struct mi *) m2;
+    const struct mi *mi1 = m1;
+    const struct mi *mi2 = m2;
     return strcmp(mi1\->name, mi2\->name);
 }