From: Dwight Engen <dwight.engen@oracle.com>
Date: Fri, 14 Feb 2014 14:49:51 +0000 (-0500)
Subject: coverity: fix resource leak
X-Git-Tag: lxc-1.0.0.rc2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=684efc5ea1b1dd3e0de4013d97b2eefe1022a4a6;p=thirdparty%2Flxc.git

coverity: fix resource leak

also fix the check if the string will fit the local buffer

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
---

diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c
index 41ba3d337..e4bd7349c 100644
--- a/src/lxc/cgmanager.c
+++ b/src/lxc/cgmanager.c
@@ -422,8 +422,10 @@ static inline bool cgm_create(void *hdata)
 	tmp = lxc_string_replace("%n", d->name, d->cgroup_pattern);
 	if (!tmp)
 		return false;
-	if (strlen(tmp) > MAXPATHLEN)
+	if (strlen(tmp) >= MAXPATHLEN) {
+		free(tmp);
 		return false;
+	}
 	strcpy(result, tmp);
 	baselen = strlen(result);
 	free(tmp);