From: Eliad Peller Date: Thu, 10 Dec 2015 10:56:06 +0000 (+0200) Subject: wpa_cli: Send ALL_STA command to the correct interface X-Git-Tag: hostap_2_6~1176 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=685ea2f60c2fc09aac83733fcb8a7c8505ebaca4;p=thirdparty%2Fhostap.git wpa_cli: Send ALL_STA command to the correct interface wpa_ctrl_command_sta(), called by the "ALL_STA" handler, didn't consider ifname_prefix, resulting in various commands being sent to the global control interface, rather than the specified interface when IFNAME= prefix was used. This in turn caused the unexpected "UNKNOWN COMMAND" result be considered as valid station, resulting in infinite loop while trying to get all stations. Fix it by considering ifname_prefix, similarly to _wpa_ctrl_command(). Signed-off-by: Eliad Peller --- diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c index 275bf392d..cef18ba8e 100644 --- a/wpa_supplicant/wpa_cli.c +++ b/wpa_supplicant/wpa_cli.c @@ -1927,6 +1927,12 @@ static int wpa_ctrl_command_sta(struct wpa_ctrl *ctrl, char *cmd, printf("Not connected to hostapd - command dropped.\n"); return -1; } + if (ifname_prefix) { + os_snprintf(buf, sizeof(buf), "IFNAME=%s %s", + ifname_prefix, cmd); + buf[sizeof(buf) - 1] = '\0'; + cmd = buf; + } len = sizeof(buf) - 1; ret = wpa_ctrl_request(ctrl, cmd, os_strlen(cmd), buf, &len, wpa_cli_msg_cb);