From: Jerry DeLisle Date: Fri, 23 Feb 2018 19:53:04 +0000 (+0000) Subject: backport: re PR fortran/84506 (INQUIRE(pos=) always sets pos=0 with -fdefault-integer-8) X-Git-Tag: releases/gcc-6.5.0~506 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6864b9f8bd204129b7c8939b9c800cf10eee3ab5;p=thirdparty%2Fgcc.git backport: re PR fortran/84506 (INQUIRE(pos=) always sets pos=0 with -fdefault-integer-8) 2018-02-23 Jerry DeLisle Backport from trunk PR fortran/84506 * trans-io.c (set_parameter_value_inquire): Adjust range check of negative unit values for kind=8 units to the kind=4 negative limit. * gfortran.dg/inquire_19.f90: New test. From-SVN: r257951 --- diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 8689c7d23a8c..e5265bf55cad 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,10 @@ +2018-02-23 Jerry DeLisle + + Backport from trunk + PR fortran/84506 + * trans-io.c (set_parameter_value_inquire): Adjust range check of + negative unit values for kind=8 units to the kind=4 negative limit. + 2018-02-23 Steven G. Kargl PR fortran/84511 diff --git a/gcc/fortran/trans-io.c b/gcc/fortran/trans-io.c index ed3a9b19517c..a6764a175d7f 100644 --- a/gcc/fortran/trans-io.c +++ b/gcc/fortran/trans-io.c @@ -611,12 +611,12 @@ set_parameter_value_inquire (stmtblock_t *block, tree var, /* Don't evaluate the UNIT number multiple times. */ se.expr = gfc_evaluate_now (se.expr, &se.pre); - /* UNIT numbers should be greater than zero. */ + /* UNIT numbers should be greater than the min. */ i = gfc_validate_kind (BT_INTEGER, 4, false); + val = gfc_conv_mpz_to_tree (gfc_integer_kinds[i].pedantic_min_int, 4); cond1 = build2_loc (input_location, LT_EXPR, boolean_type_node, se.expr, - fold_convert (TREE_TYPE (se.expr), - integer_zero_node)); + fold_convert (TREE_TYPE (se.expr), val)); /* UNIT numbers should be less than the max. */ val = gfc_conv_mpz_to_tree (gfc_integer_kinds[i].huge, 4); cond2 = build2_loc (input_location, GT_EXPR, boolean_type_node, diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 282189c69218..8337c4c3b9d3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2018-02-23 Jerry DeLisle + + Backport from trunk + PR fortran/84506 + * gfortran.dg/inquire_19.f90: New test. + 2018-02-23 Steven G. Kargl PR fortran/84346 diff --git a/gcc/testsuite/gfortran.dg/inquire_19.f90 b/gcc/testsuite/gfortran.dg/inquire_19.f90 new file mode 100644 index 000000000000..7d01b6b56ce1 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/inquire_19.f90 @@ -0,0 +1,13 @@ +! { dg-do run } +! PR84506 INQUIRE(pos=) always sets pos=0 with -fdefault-integer-8 +program TestInquire + implicit none + integer(8) :: iUnit + integer(8) :: iPos + open(newunit=iunit, file='output.txt', access='stream', status='replace') + write(iUnit) 'TEXT' + inquire(iUnit, pos=iPos) + close(iUnit, status='delete') + !print *, iPos + if (iPos.ne.5) stop 1 +end program TestInquire