From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 9 Dec 2024 13:39:03 +0000 (+0100)
Subject: dnsdist: Add a regression test rewriting the response code via Lua
X-Git-Tag: dnsdist-2.0.0-alpha1~186^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6873c26fcc97db30beaec3ff41ffcb5c10612b79;p=thirdparty%2Fpdns.git

dnsdist: Add a regression test rewriting the response code via Lua
---

diff --git a/regression-tests.dnsdist/test_Responses.py b/regression-tests.dnsdist/test_Responses.py
index af16a644bf..26c1042c0a 100644
--- a/regression-tests.dnsdist/test_Responses.py
+++ b/regression-tests.dnsdist/test_Responses.py
@@ -505,3 +505,64 @@ class TestResponseClearRecordsType(DNSDistTest):
             receivedQuery.id = query.id
             self.assertEqual(query, receivedQuery)
             self.assertEqual(expectedResponse, receivedResponse)
+
+class TestResponseRewriteServFail(DNSDistTest):
+
+    _config_params = ['_testServerPort']
+    _config_template = """
+    newServer{address="127.0.0.1:%s"}
+
+    function rewriteServFail(dq)
+      if dq.rcode == DNSRCode.SERVFAIL then
+         dq.rcode = DNSRCode.NOERROR
+        return DNSResponseAction.HeaderModify
+      end
+      return DNSResponse.None
+    end
+    addResponseAction(AndRule({QTypeRule(DNSQType.AAAA),RCodeRule(DNSRCode.SERVFAIL)}), LuaResponseAction(rewriteServFail))
+    """
+
+    def testRewriteServFail(self):
+        """
+        Responses: Rewrite AAAA ServFails as NoError (don't ask)
+        """
+        name = 'rewrite-servfail.responses.tests.powerdns.com.'
+
+        query = dns.message.make_query(name, 'AAAA', 'IN')
+        response = dns.message.make_response(query)
+        expectedResponse = dns.message.make_response(query)
+
+        response.set_rcode(dns.rcode.SERVFAIL)
+        expectedResponse.set_rcode(dns.rcode.NOERROR)
+
+        rrset = dns.rrset.from_text(name,
+                                    3660,
+                                    dns.rdataclass.IN,
+                                    dns.rdatatype.AAAA,
+                                    '2001:DB8::1', '2001:DB8::2')
+        response.answer.append(rrset)
+        expectedResponse.answer.append(rrset)
+
+        for method in ("sendUDPQuery", "sendTCPQuery"):
+            sender = getattr(self, method)
+            (receivedQuery, receivedResponse) = sender(query, response)
+            receivedQuery.id = query.id
+            self.assertEqual(query, receivedQuery)
+            self.assertEqual(expectedResponse, receivedResponse)
+
+        # but ServFail for a different type should stay the same
+        query = dns.message.make_query(name, 'A', 'IN')
+        response = dns.message.make_response(query)
+        response.set_rcode(dns.rcode.SERVFAIL)
+        rrset = dns.rrset.from_text(name,
+                                    3600,
+                                    dns.rdataclass.IN,
+                                    dns.rdatatype.A,
+                                    '192.0.2.1')
+        response.answer.append(rrset)
+        for method in ("sendUDPQuery", "sendTCPQuery"):
+            sender = getattr(self, method)
+            (receivedQuery, receivedResponse) = sender(query, response)
+            receivedQuery.id = query.id
+            self.assertEqual(query, receivedQuery)
+            self.assertEqual(response, receivedResponse)