From: Neil Brown <neilb@suse.de>
Date: Mon, 21 May 2007 04:25:30 +0000 (+1000)
Subject: Fix handling of negative bitmap offsets on 64bit hosts.
X-Git-Tag: mdadm-2.6.2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68754bd17c81377091e509367e8d0cf9c80369a5;p=thirdparty%2Fmdadm.git

Fix handling of negative bitmap offsets on 64bit hosts.

The bitmap offset is a signed 32bit number, so casting to (long)
isn't sufficient.  We must cast to (int32_t).
---

diff --git a/ANNOUNCE-2.6.2 b/ANNOUNCE-2.6.2
new file mode 100644
index 00000000..e69de29b
diff --git a/super1.c b/super1.c
index efe8a460..5995bb61 100644
--- a/super1.c
+++ b/super1.c
@@ -215,7 +215,7 @@ static void examine_super1(void *sbv, char *homehost)
 	printf("\n");
 	if (sb->feature_map & __cpu_to_le32(MD_FEATURE_BITMAP_OFFSET)) {
 		printf("Internal Bitmap : %ld sectors from superblock\n",
-		       (long)__le32_to_cpu(sb->bitmap_offset));
+		       (long)(int32_t)__le32_to_cpu(sb->bitmap_offset));
 	}
 	if (sb->feature_map & __le32_to_cpu(MD_FEATURE_RESHAPE_ACTIVE)) {
 		printf("  Reshape pos'n : %llu%s\n", (unsigned long long)__le64_to_cpu(sb->reshape_position)/2,
@@ -1276,7 +1276,7 @@ static void locate_bitmap1(struct supertype *st, int fd, void *sbv)
 	sb = sbv;
 
 	offset = __le64_to_cpu(sb->super_offset);
-	offset += (long) __le32_to_cpu(sb->bitmap_offset);
+	offset += (int32_t) __le32_to_cpu(sb->bitmap_offset);
 	if (mustfree)
 		free(sb);
 	lseek64(fd, offset<<9, 0);
diff --git a/tests/02lineargrow b/tests/02lineargrow
new file mode 100644
index 00000000..e69de29b
diff --git a/tests/07autodetect b/tests/07autodetect
new file mode 100644
index 00000000..e69de29b