From: Xu Jia <xujia39@huawei.com>
Date: Wed, 24 Mar 2021 07:20:31 +0000 (+0800)
Subject: applicom: fix some err codes returned by ac_ioctl
X-Git-Tag: v5.13-rc1~175^2~68
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6880149e5a78962a055720981d37e5069f296ef7;p=thirdparty%2Fkernel%2Flinux.git

applicom: fix some err codes returned by ac_ioctl

When cmd > 6 or copy_to_user() fail, The variable 'ret' would not be
returned back. Fix the 'ret' set but not used.

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Xu Jia <xujia39@huawei.com>
Link: https://lore.kernel.org/r/20210324072031.941791-1-xujia39@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index 14b2d8034c51d..0ab7651433540 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -839,7 +839,7 @@ static long ac_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	Dummy = readb(apbs[IndexCard].RamIO + VERS);
 	kfree(adgl);
 	mutex_unlock(&ac_mutex);
-	return 0;
+	return ret;
 
 err:
 	if (warncount) {