From: Philippe Antoine <contact@catenacyber.fr>
Date: Mon, 5 Jun 2023 06:43:05 +0000 (+0200)
Subject: output/dns: do not add empty app-layer metadata
X-Git-Tag: suricata-8.0.0-beta1~1488
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=688efe79f0975d98157ae9502c99c8c1172e5fe3;p=thirdparty%2Fsuricata.git

output/dns: do not add empty app-layer metadata
---

diff --git a/src/output-json-dns.c b/src/output-json-dns.c
index 3c7009b501..9cab2bde55 100644
--- a/src/output-json-dns.c
+++ b/src/output-json-dns.c
@@ -293,19 +293,22 @@ static JsonBuilder *JsonDNSLogAnswer(void *txptr)
 
 bool AlertJsonDns(void *txptr, JsonBuilder *js)
 {
+    bool r = false;
     jb_open_object(js, "dns");
     JsonBuilder *qjs = JsonDNSLogQuery(txptr);
     if (qjs != NULL) {
         jb_set_object(js, "query", qjs);
         jb_free(qjs);
+        r = true;
     }
     JsonBuilder *ajs = JsonDNSLogAnswer(txptr);
     if (ajs != NULL) {
         jb_set_object(js, "answer", ajs);
         jb_free(ajs);
+        r = true;
     }
     jb_close(js);
-    return true;
+    return r;
 }
 
 static int JsonDnsLoggerToServer(ThreadVars *tv, void *thread_data,