From: Greg Hudson <ghudson@mit.edu>
Date: Wed, 29 Jun 2016 02:10:35 +0000 (-0400)
Subject: Fix unlikely leak in sendto_kdc
X-Git-Tag: krb5-1.15-beta1~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6895dc9f204520e7f4da8da879cc67c149bc4e6b;p=thirdparty%2Fkrb5.git

Fix unlikely leak in sendto_kdc

If a TCP connection is killed after it allocates the buffer (so is no
longer in READING state), free the buffer during cleanup.

ticket: 8444 (new)
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
---

diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c
index a2b735901f..b3b8173bec 100644
--- a/src/lib/krb5/os/sendto_kdc.c
+++ b/src/lib/krb5/os/sendto_kdc.c
@@ -1578,7 +1578,7 @@ cleanup:
             closesocket(state->fd);
             free_http_tls_data(context, state);
         }
-        if (state->state == READING && state->in.buf != udpbuf)
+        if (state->in.buf != udpbuf)
             free(state->in.buf);
         if (callback_info) {
             callback_info->pfn_cleanup(callback_info->data,