From: Andreas Schneider Date: Mon, 12 Aug 2019 16:49:31 +0000 (+0200) Subject: Revert "libcli:auth: Use generate_secret_buffer() for netlogon challenge" X-Git-Tag: tdb-1.4.2~119 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=689760f26521fe5b4c8964a25ddd3ab1c9e9977c;p=thirdparty%2Fsamba.git Revert "libcli:auth: Use generate_secret_buffer() for netlogon challenge" This reverts commit c3ba556f52b15dd80efc26e4fb8f43ce2ee3a7f0. Reviewed-by: Alexander Bokovoy --- diff --git a/libcli/auth/netlogon_creds_cli.c b/libcli/auth/netlogon_creds_cli.c index 18143ca36d0..50a5f50a57d 100644 --- a/libcli/auth/netlogon_creds_cli.c +++ b/libcli/auth/netlogon_creds_cli.c @@ -1177,8 +1177,7 @@ static void netlogon_creds_cli_auth_challenge_start(struct tevent_req *req) TALLOC_FREE(state->creds); - /* We need to use a CSPRNG which reseeds for generating session keys. */ - generate_secret_buffer(state->client_challenge.data, + generate_random_buffer(state->client_challenge.data, sizeof(state->client_challenge.data)); subreq = dcerpc_netr_ServerReqChallenge_send(state, state->ev,