From: Dylan William Hardison <dylan@hardison.net>
Date: Mon, 2 Feb 2015 12:57:22 +0000 (-0500)
Subject: Bug 1128245 - upgrading from v4.4.6 to v5.0rc2 fails on connection problem with MySQL
X-Git-Tag: bugzilla-5.0rc3~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=689f76e37a3958097b3e1d88561b9a8d19f1f41a;p=thirdparty%2Fbugzilla.git

Bug 1128245 - upgrading from v4.4.6 to v5.0rc2 fails on connection problem with MySQL
---

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index fdbedbdc04..1e22b52397 100644
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -335,7 +335,9 @@ sub read_param_file {
             die "Error parsing $file: $error_msg";
         }
         # JSON::XS doesn't detaint data for us.
-        trick_taint($params{$_}) foreach keys %params;
+        foreach my $key (keys %params) {
+            trick_taint($params{$key}) if defined $params{$key};
+        }
     }
     elsif ($ENV{'SERVER_SOFTWARE'}) {
        # We're in a CGI, but the params file doesn't exist. We can't