From: Carl Love Date: Thu, 28 Jul 2016 16:51:53 +0000 (+0000) Subject: When running the valgrind tests, the jm-insns test is segfaulting when it X-Git-Tag: svn/VALGRIND_3_12_0~106 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68a17eeb242d33517281a0153fcc9bc9cf8a1507;p=thirdparty%2Fvalgrind.git When running the valgrind tests, the jm-insns test is segfaulting when it attempts to patch instructions as it deals with the ppc64 (BE) function descriptor. This is actually due to the RELRO option being enabled by default for the ppc64 (BE) platform, per an upstream binutils change. Bugzilla 365912 reported by Will Schmidt, Will supplied the patch to fix the make file none/tests/ppc64/Makefile.a Patch tested on Power 7 and Power 8. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15917 --- diff --git a/NEWS b/NEWS index dd635b9445..238ba02eee 100644 --- a/NEWS +++ b/NEWS @@ -135,6 +135,7 @@ where XXXXXX is the bug number as listed below. 364728 Power PC, missing support for several HW registers in get_otrack_shadow_offset_wrk() 365273 Invalid write to stack location reported after signal handler runs +365912 ppc64BE segfault during jm-insns test (RELRO) n-i-bz Fix incorrect (or infinite loop) unwind on RHEL7 x86 and amd64 n-i-bz massif --pages-as-heap=yes does not report peak caused by mmap+munmap diff --git a/none/tests/ppc64/Makefile.am b/none/tests/ppc64/Makefile.am index f8ec728601..f68d69e257 100644 --- a/none/tests/ppc64/Makefile.am +++ b/none/tests/ppc64/Makefile.am @@ -95,7 +95,7 @@ else HTM_FLAG = endif -jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \ +jm_insns_CFLAGS = $(AM_CFLAGS) -Wl,-z,norelro -Winline -Wall -O -g -mregnames \ @FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC) if HAS_ISA_3_0