From: Joe Orton <jorton@apache.org>
Date: Fri, 5 Oct 2018 14:05:20 +0000 (+0000)
Subject: * server/protocol.c (ap_rvputs): Call va_end before returning in the
X-Git-Tag: 2.5.0-alpha2-ci-test-only~2299
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68b0e99b652b5bdd4d041d8e1f1e2b5f5069f9cf;p=thirdparty%2Fapache%2Fhttpd.git

* server/protocol.c (ap_rvputs): Call va_end before returning in the
  error case, as required by C89/POSIX stdarg.h - Coverity warns for
  this.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1842919 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/protocol.c b/server/protocol.c
index c43ce117e61..a95e6a06d72 100644
--- a/server/protocol.c
+++ b/server/protocol.c
@@ -2211,6 +2211,7 @@ AP_DECLARE_NONSTD(int) ap_rvputs(request_rec *r, ...)
 
         len = strlen(s);
         if (buffer_output(r, s, len) != APR_SUCCESS) {
+            va_end(va);
             return -1;
         }