From: Andrea Bolognani <abologna@redhat.com>
Date: Thu, 26 Jan 2023 15:36:34 +0000 (+0100)
Subject: conf: Export virDomainDefOSValidate()
X-Git-Tag: v9.2.0-rc1~253
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68b80a705cc006016d4c832d6fde002fb82c6814;p=thirdparty%2Flibvirt.git

conf: Export virDomainDefOSValidate()

We're going to need it elsewhere very soon.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index 5559a71e14..db13e56107 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -1586,14 +1586,14 @@ virDomainDefMemtuneValidate(const virDomainDef *def)
 }
 
 
-static int
+int
 virDomainDefOSValidate(const virDomainDef *def,
                        virDomainXMLOption *xmlopt)
 {
     virDomainLoaderDef *loader = def->os.loader;
 
     if (def->os.firmware) {
-        if (!(xmlopt->config.features & VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT)) {
+        if (xmlopt && !(xmlopt->config.features & VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT)) {
             virReportError(VIR_ERR_XML_DETAIL, "%s",
                            _("firmware auto selection not implemented for this driver"));
             return -1;
diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h
index 07b99195e3..fc441cef5b 100644
--- a/src/conf/domain_validate.h
+++ b/src/conf/domain_validate.h
@@ -44,3 +44,6 @@ int virDomainDiskDefValidateSource(const virStorageSource *src);
 int virDomainDiskDefValidateStartupPolicy(const virDomainDiskDef *disk);
 
 int virDomainDiskDefSourceLUNValidate(const virStorageSource *src);
+
+int virDomainDefOSValidate(const virDomainDef *def,
+                           virDomainXMLOption *xmlopt);
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 67254b6ac8..b249dcc85c 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -795,6 +795,7 @@ virDomainDefPostParse;
 
 # conf/domain_validate.h
 virDomainActualNetDefValidate;
+virDomainDefOSValidate;
 virDomainDefValidate;
 virDomainDeviceValidateAliasForHotplug;
 virDomainDiskDefSourceLUNValidate;