From: Carter Waxman <cwaxman@cisco.com>
Date: Mon, 11 Apr 2016 15:01:45 +0000 (-0400)
Subject: fixed hinkiness
X-Git-Tag: 3.0.0-233~462^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68c6f7518e820ffed47eef195f2b0a28fa2fb0e6;p=thirdparty%2Fsnort3.git

fixed hinkiness
---

diff --git a/src/network_inspectors/perf_monitor/perf_module.cc b/src/network_inspectors/perf_monitor/perf_module.cc
index 263a7be7b..1ff85433c 100644
--- a/src/network_inspectors/perf_monitor/perf_module.cc
+++ b/src/network_inspectors/perf_monitor/perf_module.cc
@@ -192,7 +192,7 @@ bool PerfMonModule::begin(const char* fqn, int, SnortConfig*)
     return true;
 }
 
-static bool add_module(PerfConfig& config, Module *mod, std::string pegs)
+static bool add_module(PerfConfig& config, Module *mod, std::string& pegs)
 {
     const PegInfo* peg_info;
     std::string tok;
@@ -236,9 +236,11 @@ bool PerfMonModule::end(const char* fqn, int idx, SnortConfig*)
         if ( !config.modules.size() )
         {
             auto modules = ModuleManager::get_all_modules();
+            std::string empty;
+
             for ( auto& mod : modules )
             {
-                if ( !add_module(config, mod, std::string()) )
+                if ( !add_module(config, mod, empty) )
                     return false;
             }
         }