From: Mike Yuan <me@yhndnzj.com>
Date: Sun, 1 Jun 2025 07:04:27 +0000 (+0200)
Subject: sd-login: reject invalid pidfd with -EBADF consistently
X-Git-Tag: v258-rc1~390^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=68db777ae26569ad9630aaa91547f4ee549276a6;p=thirdparty%2Fsystemd.git

sd-login: reject invalid pidfd with -EBADF consistently

We got it mostly right except for one function, fix it.
---

diff --git a/src/libsystemd/sd-login/sd-login.c b/src/libsystemd/sd-login/sd-login.c
index d730c5673c3..133e97b4328 100644
--- a/src/libsystemd/sd-login/sd-login.c
+++ b/src/libsystemd/sd-login/sd-login.c
@@ -273,7 +273,7 @@ _public_ int sd_pidfd_get_owner_uid(int pidfd, uid_t *ret_uid) {
         pid_t pid;
         int r;
 
-        assert_return(pidfd >= 0, -EINVAL);
+        assert_return(pidfd >= 0, -EBADF);
 
         r = pidfd_get_pid(pidfd, &pid);
         if (r < 0)