From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 3 Jun 2022 11:37:00 +0000 (+0200)
Subject: virDomainHugepagesFormat: Use virXMLFormatElementEmpty
X-Git-Tag: v8.5.0-rc1~73
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=690053825491fbed4bca69f65decbc20d06d7ee3;p=thirdparty%2Flibvirt.git

virDomainHugepagesFormat: Use virXMLFormatElementEmpty

Refactor the function to use modern XML formatting machinery.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d3aa827acc..9891c5c087 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27186,22 +27186,15 @@ virDomainHugepagesFormat(virBuffer *buf,
                          virDomainHugePage *hugepages,
                          size_t nhugepages)
 {
+    g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);
     size_t i;
 
-    if (nhugepages == 1 &&
-        hugepages[0].size == 0) {
-        virBufferAddLit(buf, "<hugepages/>\n");
-        return;
+    if (nhugepages != 1 || hugepages[0].size != 0) {
+        for (i = 0; i < nhugepages; i++)
+            virDomainHugepagesFormatBuf(&childBuf, &hugepages[i]);
     }
 
-    virBufferAddLit(buf, "<hugepages>\n");
-    virBufferAdjustIndent(buf, 2);
-
-    for (i = 0; i < nhugepages; i++)
-        virDomainHugepagesFormatBuf(buf, &hugepages[i]);
-
-    virBufferAdjustIndent(buf, -2);
-    virBufferAddLit(buf, "</hugepages>\n");
+    virXMLFormatElementEmpty(buf, "hugepages", NULL, &childBuf);
 }