From: Chen Qi Date: Thu, 18 Dec 2025 02:53:51 +0000 (+0800) Subject: insane.bbclass: avoid unnecessary rerun of do_patch X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=693b862db479ecb4c15b6e755ccb4ed30cf91fa8;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git insane.bbclass: avoid unnecessary rerun of do_patch When toggling ptest for DISTRO_FEATURES, the do_patch function gets rerun. The dependency chain is: do_patch -> do_qa_patch -> DISTRO_FEATURES{ptest} Such rerun is not necessary. And it's kind of annoying because everything gets rebuilt, including cross toolchain and recipes not using ptest. The ERROR_QA and WARN_QA should be enough to trigger the re-run if unimplemented-ptest is added to one of them. So remove the first check of DISTRO_FEATURES on ptest to avoid these unnecessary reruns. Signed-off-by: Chen Qi Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index fed8163c3e..aeffee7983 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1305,9 +1305,7 @@ python do_qa_patch() { return False srcdir = d.getVar('S') - if not bb.utils.contains('DISTRO_FEATURES', 'ptest', True, False, d): - pass - elif not (bb.utils.contains('ERROR_QA', 'unimplemented-ptest', True, False, d) or bb.utils.contains('WARN_QA', 'unimplemented-ptest', True, False, d)): + if not (bb.utils.contains('ERROR_QA', 'unimplemented-ptest', True, False, d) or bb.utils.contains('WARN_QA', 'unimplemented-ptest', True, False, d)): pass elif bb.data.inherits_class('ptest', d): bb.note("Package %s QA: skipping unimplemented-ptest: ptest implementation detected" % d.getVar('PN'))