From: justdave%syndicomm.com <>
Date: Wed, 14 Apr 2004 04:45:35 +0000 (+0000)
Subject: Bug 240439: "Edit user again" link didn't work if the user had a + in their email... 
X-Git-Tag: bugzilla-2.18rc1~89
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=699734a99b43b601c881813db8f5a32788558c17;p=thirdparty%2Fbugzilla.git

Bug 240439: "Edit user again" link didn't work if the user had a + in their email address
R= timeless, vladd; a= justdave
---

diff --git a/editusers.cgi b/editusers.cgi
index 36135a1e2c..aa760b1e1e 100755
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -844,7 +844,7 @@ if ($action eq 'update') {
     if ($editall && $user ne $userold) {
         unless ($user) {
             print "Sorry, I can't delete the user's name.";
-            $userold = value_quote($userold);
+            $userold = url_quote($userold);
             $localtrailer =~ s/XXX/$userold/;
             push @localtrailers, $localtrailer;
             PutTrailer(@localtrailers);
@@ -852,7 +852,7 @@ if ($action eq 'update') {
         }
         if (TestUser($user)) {
             print "Sorry, user name '$user' is already in use.";
-            $userold = value_quote($userold);
+            $userold = url_quote($userold);
             $localtrailer =~ s/XXX/$userold/;
             push @localtrailers, $localtrailer;
             PutTrailer($localtrailer);
@@ -864,12 +864,12 @@ if ($action eq 'update') {
                  WHERE login_name=" . SqlQuote($userold));
 
         print q|Updated user's name to <a href="mailto:| .
-              value_quote($user) . '">' . html_quote($user) . "</a>.<BR>\n";
+              url_quote($user) . '">' . html_quote($user) . "</a>.<BR>\n";
     }
     my $changeduser = new Bugzilla::User($thisuserid);
     $changeduser->derive_groups();
 
-    $user = value_quote($user);
+    $user = url_quote($user);
     $localtrailer =~ s/XXX/$user/;
     push @localtrailers, $localtrailer;
     PutTrailer(@localtrailers);