From: John Ferlan <jferlan@redhat.com>
Date: Thu, 25 May 2017 13:35:58 +0000 (-0400)
Subject: nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild
X-Git-Tag: v3.6.0-rc1~166
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69979369bb8e1de8ad991f5756d9ee5f4bb3df0d;p=thirdparty%2Flibvirt.git

nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild

Should compare < 0 to be correct.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c
index b5aaa6b0d4..0027d45b61 100644
--- a/src/conf/virnwfilterobj.c
+++ b/src/conf/virnwfilterobj.c
@@ -253,7 +253,7 @@ virNWFilterObjTestUnassignDef(virNWFilterObjPtr obj)
 
     obj->wantRemoved = true;
     /* trigger the update on VMs referencing the filter */
-    if (virNWFilterTriggerVMFilterRebuild())
+    if (virNWFilterTriggerVMFilterRebuild() < 0)
         rc = -1;
 
     obj->wantRemoved = false;
@@ -345,7 +345,7 @@ virNWFilterObjListAssignDef(virNWFilterObjListPtr nwfilters,
 
         obj->newDef = def;
         /* trigger the update on VMs referencing the filter */
-        if (virNWFilterTriggerVMFilterRebuild()) {
+        if (virNWFilterTriggerVMFilterRebuild() < 0) {
             obj->newDef = NULL;
             virNWFilterObjUnlock(obj);
             return NULL;