From: Jim Meyering <jim@meyering.net>
Date: Sun, 18 Apr 1999 15:57:19 +0000 (+0000)
Subject: (tempname): Add a FIXME comment.
X-Git-Tag: TEXTUTILS-1_22j~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69b1c4026ccea8f653d3f7908dcdbf85ff75da98;p=thirdparty%2Fcoreutils.git

(tempname): Add a FIXME comment.
---

diff --git a/src/sort.c b/src/sort.c
index d69cb4f050..5918b6a6fc 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -450,10 +450,15 @@ tempname (void)
 	     (len && temp_dir[len - 1] != '/') ? "/" : "",
 	     (unsigned int) getpid () & 0xffff, seq);
   else
-    sprintf (name, "%s%ss%5.5d%2.2d.%3.3d",
-	     temp_dir,
-	     (len && temp_dir[len - 1] != '/') ? "/" : "",
-	     (unsigned int) getpid () & 0xffff, seq / 1000, seq % 1000);
+    {
+      sprintf (name, "%s%ss%5.5d%2.2d.%3.3d",
+	       temp_dir,
+	       (len && temp_dir[len - 1] != '/') ? "/" : "",
+	       (unsigned int) getpid () & 0xffff, seq / 1000, seq % 1000);
+
+      /* FIXME: fail if seq exceeds 99999 -- at which point sort
+	 would start reusing temporary file names.  */
+    }
 
   /* Make sure that SEQ's value fits in 5 digits.  */
   ++seq;