From: Joshua Rogers <MegaManSec@users.noreply.github.com>
Date: Tue, 9 Sep 2025 17:15:26 +0000 (+0000)
Subject: Do not leak file handle on _open_osfhandle() failure (#2222)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69df8e876ad712a5cd94fd736587032a8c016b6c;p=thirdparty%2Fsquid.git

Do not leak file handle on _open_osfhandle() failure (#2222)
---

diff --git a/compat/socket.cc b/compat/socket.cc
index 16bca103c4..5fac7c2244 100644
--- a/compat/socket.cc
+++ b/compat/socket.cc
@@ -225,8 +225,11 @@ xsocket(int domain, int type, int protocol)
         return SOCKET_ERROR;
     }
     const auto rv = _open_osfhandle(result, 0);
-    if (rv == -1)
+    if (rv == -1) {
+        closesocket(result);
         errno = EBADF;
+        return SOCKET_ERROR;
+    }
     return rv;
 }