From: Stephen Hemminger Date: Sat, 27 Jan 2024 21:58:14 +0000 (-0800) Subject: bpf: fix warning from basename() X-Git-Tag: v6.8.0~28 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69e3b2fadcd32683db2942f31fe41f0fbb2185f8;p=thirdparty%2Fiproute2.git bpf: fix warning from basename() The function basename() expects a mutable character string, which now causes a warning: bpf_legacy.c: In function ‘bpf_load_common’: bpf_legacy.c:975:38: warning: passing argument 1 of ‘__xpg_basename’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 975 | basename(cfg->object), cfg->mode == EBPF_PINNED ? | ~~~^~~~~~~~ In file included from bpf_legacy.c:21: /usr/include/libgen.h:34:36: note: expected ‘char *’ but argument is of type ‘const char *’ 34 | extern char *__xpg_basename (char *__path) __THROW; Fixes: f20ff2f19552 ("bpf: keep parsed program mode in struct bpf_cfg_in") Signed-off-by: Stephen Hemminger --- diff --git a/lib/bpf_legacy.c b/lib/bpf_legacy.c index 741eec8d4..c8da4a3e6 100644 --- a/lib/bpf_legacy.c +++ b/lib/bpf_legacy.c @@ -972,8 +972,8 @@ int bpf_load_common(struct bpf_cfg_in *cfg, const struct bpf_cfg_ops *ops, ops->cbpf_cb(nl, cfg->opcodes, cfg->n_opcodes); if (cfg->mode == EBPF_OBJECT || cfg->mode == EBPF_PINNED) { snprintf(annotation, sizeof(annotation), "%s:[%s]", - basename(cfg->object), cfg->mode == EBPF_PINNED ? - "*fsobj" : cfg->section); + basename(strdupa(cfg->object)), + cfg->mode == EBPF_PINNED ? "*fsobj" : cfg->section); ops->ebpf_cb(nl, cfg->prog_fd, annotation); }