From: Tycho Andersen <tycho.andersen@canonical.com>
Date: Mon, 13 Apr 2015 22:43:30 +0000 (-0600)
Subject: don't compare unsigned values as negative ones
X-Git-Tag: lxc-2.0.0.beta1~311
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69f97e3c12fb76cb7e7f740dc0bcd0aadf14451f;p=thirdparty%2Flxc.git

don't compare unsigned values as negative ones

Instead, check that the result is larger than its parts.

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
---

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 084b5563e..fe71e9aa4 100644
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1645,12 +1645,13 @@ int setproctitle(char *title)
 			env_start = env_end;
 		}
 
+		arg_end = arg_start + len;
+
 		/* check overflow */
-		if (arg_start + len < 0) {
+		if (arg_end < len || arg_end < arg_start) {
 			return -1;
 		}
 
-		arg_end = arg_start + len;
 	}
 
 	strcpy((char*)arg_start, title);