From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 29 Oct 2021 12:55:59 +0000 (+0200)
Subject: BUG/MEDIUM: stream-int: Block reads if channel cannot receive more data
X-Git-Tag: v2.5-dev12~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69fad00ebf65ad0dedabaf10db43fb3783f7ecae;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: stream-int: Block reads if channel cannot receive more data

First of all, we must be careful here because this part was modified and
each time, this introduced a bug. But, in si_update_rx(), we must not
re-enables receives if the channel buffer cannot receive more
data. Otherwise the multiplexer will be wake up for nothing. Because the
stream is woken up when the multiplexer is waiting for more room to move on,
this may lead to a ping-pong loop between the stream and the mux.

Note that for now, it does not fix any known bug. All reported issues in
this area were fixed in another way.

This patch must be backported with a special care. Technically speaking, it
may be backported as far as 2.0.
---

diff --git a/src/stream_interface.c b/src/stream_interface.c
index b55515901c..8ad1854970 100644
--- a/src/stream_interface.c
+++ b/src/stream_interface.c
@@ -838,7 +838,7 @@ void si_update_rx(struct stream_interface *si)
 	else
 		si_rx_chan_rdy(si);
 
-	if (!channel_is_empty(ic)) {
+	if (!channel_is_empty(ic) || !channel_may_recv(ic)) {
 		/* stop reading, imposed by channel's policy or contents */
 		si_rx_room_blk(si);
 	}