From: Volker Lendecke <vl@samba.org>
Date: Thu, 2 Oct 2025 12:09:50 +0000 (+0200)
Subject: vfs_streams_depot: Use NEXT_UNLINKAT when deleting a stream
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a02d7d151d9386f5b8df6c15acf6474b7ed8078;p=thirdparty%2Fsamba.git

vfs_streams_depot: Use NEXT_UNLINKAT when deleting a stream

With other modules in the chain funny things can happen

I don't have a concrete bug that I could write a test for, but with
the upcoming patches this becomes necessary.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/vfs_streams_depot.c b/source3/modules/vfs_streams_depot.c
index 19b9356fd57..81a11668864 100644
--- a/source3/modules/vfs_streams_depot.c
+++ b/source3/modules/vfs_streams_depot.c
@@ -809,7 +809,6 @@ static int streams_depot_unlinkat_stream(vfs_handle_struct *handle,
 					 struct files_struct *dirfsp,
 					 const struct smb_filename *smb_fname)
 {
-	struct connection_struct *conn = handle->conn;
 	struct smb_filename sname = {};
 	struct smb_filename *base_name = NULL;
 	struct smb_filename *stream_dir = NULL;
@@ -858,7 +857,7 @@ static int streams_depot_unlinkat_stream(vfs_handle_struct *handle,
 		goto done;
 	}
 
-	ret = SMB_VFS_UNLINKAT(conn, stream_dir->fsp, &sname, 0);
+	ret = SMB_VFS_NEXT_UNLINKAT(handle, stream_dir->fsp, &sname, 0);
 done:
 	{
 		int err = errno;