From: Jan Engelhardt <jengelh@medozas.de>
Date: Mon, 31 Jan 2011 01:34:49 +0000 (+0100)
Subject: iptables: warn when parameter limit is exceeded
X-Git-Tag: v1.4.11~83
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a0448eecdee4c6a19303b75c1707915a80cbfbb;p=thirdparty%2Fiptables.git

iptables: warn when parameter limit is exceeded

While testing many match extensions in a single rule, I ran into this
error not warned about. Arguments were just ignored, causing
surprising "Need to specify an argument to --whatever" when the
argument was in fact given on the command line.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---

diff --git a/ip6tables-restore.c b/ip6tables-restore.c
index cea5f36e..9948cd63 100644
--- a/ip6tables-restore.c
+++ b/ip6tables-restore.c
@@ -103,8 +103,11 @@ static int add_argv(char *what) {
 		newargv[newargc] = strdup(what);
 		newargc++;
 		return 1;
-	} else
+	} else {
+		xtables_error(PARAMETER_PROBLEM,
+			"Parser cannot handle more arguments\n");
 		return 0;
+	}
 }
 
 static void free_argv(void) {
diff --git a/iptables-restore.c b/iptables-restore.c
index bf80e788..519d4800 100644
--- a/iptables-restore.c
+++ b/iptables-restore.c
@@ -103,8 +103,11 @@ static int add_argv(char *what) {
 		newargv[newargc] = strdup(what);
 		newargc++;
 		return 1;
-	} else 
+	} else {
+		xtables_error(PARAMETER_PROBLEM,
+			"Parser cannot handle more arguments\n");
 		return 0;
+	}
 }
 
 static void free_argv(void) {