From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Mon, 27 Nov 2023 13:21:47 +0000 (+0100)
Subject: Cleanup ssql
X-Git-Tag: rec-5.0.0-rc1~15^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a07928b7aff0419c209b7238c9a4a5c3999ef92;p=thirdparty%2Fpdns.git

Cleanup ssql
---

diff --git a/pdns/backends/gsql/ssql.hh b/pdns/backends/gsql/ssql.hh
index c1d792e2ac..dbc46a32a5 100644
--- a/pdns/backends/gsql/ssql.hh
+++ b/pdns/backends/gsql/ssql.hh
@@ -21,8 +21,9 @@
  */
 #pragma once
 #include <string>
+#include <utility>
 #include <vector>
-#include <inttypes.h>
+#include <cinttypes>
 #include "../../dnsname.hh"
 #include "../../namespaces.hh"
 #include "../../misc.hh"
@@ -30,8 +31,8 @@
 class SSqlException
 {
 public:
-  SSqlException(const string& reason) :
-    d_reason(reason)
+  SSqlException(string reason) :
+    d_reason(std::move(reason))
   {
   }
 
@@ -47,8 +48,8 @@ private:
 class SSqlStatement
 {
 public:
-  typedef vector<string> row_t;
-  typedef vector<row_t> result_t;
+  using row_t = vector<string>;
+  using result_t = vector<row_t>;
 
   virtual SSqlStatement* bind(const string& name, bool value) = 0;
   virtual SSqlStatement* bind(const string& name, int value) = 0;
@@ -92,5 +93,5 @@ public:
     return true;
   }
   virtual void reconnect(){};
-  virtual ~SSql(){};
+  virtual ~SSql() = default;
 };