From: Jeremy Allison <jra@samba.org>
Date: Fri, 18 Mar 2022 19:27:53 +0000 (-0700)
Subject: s3: smbd: call_trans2setfilepathinfo(). All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_nam... 
X-Git-Tag: tevent-0.12.0~265
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a25b6997ff9f99fde309db1e163d16cd70ca5f5;p=thirdparty%2Fsamba.git

s3: smbd: call_trans2setfilepathinfo(). All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) clobber fsp->fsp_name->st.st_ex_iflags.

If doing an SMB_VFS_FSTAT() returning onto the stat struct stored in the fsp,
we must call vfs_stat_fsp() as this preserves the iflags.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15022

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index d44599ed00a..56b5c0db902 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -9333,11 +9333,12 @@ static void call_trans2setfilepathinfo(connection_struct *conn,
 			/*
 			 * Original code - this is an open file.
 			 */
-			if (SMB_VFS_FSTAT(fsp, &smb_fname->st) != 0) {
+			status = vfs_stat_fsp(fsp);
+			if (!NT_STATUS_IS_OK(status)) {
 				DEBUG(3,("call_trans2setfilepathinfo: fstat "
 					 "of %s failed (%s)\n", fsp_fnum_dbg(fsp),
-					 strerror(errno)));
-				reply_nterror(req, map_nt_error_from_unix(errno));
+					 nt_errstr(status)));
+				reply_nterror(req, status);
 				return;
 			}
 		}