From: Yang Kun <yangkun@disroot.org>
Date: Wed, 8 Apr 2026 13:41:16 +0000 (+0200)
Subject: c++: gcc_assert(false) replaced with gcc_unreachable()
X-Git-Tag: basepoints/gcc-17~271
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a3ff2a7f5afe62f3800a90aa496d68636f83127;p=thirdparty%2Fgcc.git

c++: gcc_assert(false) replaced with gcc_unreachable()

gcc/cp/ChangeLog:
	* pt.cc (tsubst_expr): Use gcc_unreachable, not gcc_assert.
	* parser.cc (cp_parser_template_id): Likewise.
	* reflect.cc (eval_template_of): Likewise.

Signed-off-by: Yang Kun <yangkun@disroot.org>
---

diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index 7496a32f6c7..62ae24f559b 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -21337,7 +21337,7 @@ cp_parser_template_id (cp_parser *parser,
 	  return error_mark_node;
 	}
       else
-	gcc_assert (false);
+	gcc_unreachable ();
 
       template_id = lookup_template_function (templ, arguments);
       if (TREE_CODE (template_id) == TEMPLATE_ID_EXPR)
diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc
index 70418e05f91..c10ca09cdb1 100644
--- a/gcc/cp/pt.cc
+++ b/gcc/cp/pt.cc
@@ -22367,7 +22367,7 @@ tsubst_expr (tree t, tree args, tsubst_flags_t complain, tree in_decl)
 						 complain);
 	else if (concept_check_p (function))
 	  /* Calls to concepts should have been previously diagnosed.  */
-	  gcc_assert (false);
+	  gcc_unreachable ();
 	else
 	  ret = finish_call_expr (function, &call_args,
 				  /*disallow_virtual=*/qualified_p,
diff --git a/gcc/cp/reflect.cc b/gcc/cp/reflect.cc
index 2baeced1e96..3c0e029975d 100644
--- a/gcc/cp/reflect.cc
+++ b/gcc/cp/reflect.cc
@@ -2912,7 +2912,7 @@ eval_template_of (location_t loc, const constexpr_ctx *ctx, tree r,
   else if (VAR_OR_FUNCTION_DECL_P (r) && DECL_TEMPLATE_INFO (r))
     r = DECL_TI_TEMPLATE (r);
   else
-    gcc_assert (false);
+    gcc_unreachable ();
 
   gcc_assert (TREE_CODE (r) == TEMPLATE_DECL);
   return get_reflection_raw (loc, r);