From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 23 Jan 2019 09:38:48 +0000 (+0100)
Subject: virPCIGetNetName: Initialize @netname to NULL
X-Git-Tag: v5.1.0-rc1~388
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a8c1749029202539174c83aa7575af443c7fb22;p=thirdparty%2Flibvirt.git

virPCIGetNetName: Initialize @netname to NULL

This is a return argument that is to be compared against NULL on
successful return. However, it is not initialized and therefore
relies on callers setting it to NULL prior calling the function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 92ef008ca1..f3e3d442ed 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1445,8 +1445,6 @@ virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname,
 {
     int ret = -1;
 
-    *pfname = NULL;
-
     if (virNetDevGetPhysicalFunction(vfname, pfname) < 0)
         return -1;
 
diff --git a/src/util/virpci.c b/src/util/virpci.c
index 537876bcba..ef578bf774 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -2853,6 +2853,8 @@ virPCIGetNetName(const char *device_link_sysfs_path,
     struct dirent *entry = NULL;
     size_t i = 0;
 
+    *netname = NULL;
+
     if (virBuildPath(&pcidev_sysfs_net_path, device_link_sysfs_path,
                      "net") == -1) {
         virReportOOMError();