From: kiko%async.com.br <>
Date: Sat, 24 Jul 2004 07:21:49 +0000 (+0000)
Subject: Fix for bug 252370: Provide edit link for attachment in comment. Adds an
X-Git-Tag: bugzilla-2.18rc2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6a9a1d223a7b2d5150939c084241fde697f8fa49;p=thirdparty%2Fbugzilla.git

Fix for bug 252370: Provide edit link for attachment in comment. Adds an
[edit] link next to attachments in comment text, and removes the                       &action=view suffix which breaks things when pasting into a shell.                     r=bugreport, myk; a=myk.
---

diff --git a/globals.pl b/globals.pl
index 6632833abd..e31c8e7179 100644
--- a/globals.pl
+++ b/globals.pl
@@ -968,10 +968,10 @@ sub GetAttachmentLink {
     # Now that we know we've got all the information we're gonna get, let's
     # return the link (which is the whole reason we were called :)
     my ($title, $className) = @{$::attachlink{$attachid}};
-    # $title will be undefined if the bug didn't exist in the database.
+    # $title will be undefined if the attachment didn't exist in the database.
     if (defined $title) {
-        my $linkval = "attachment.cgi?id=$attachid&amp;action=view";
-        return qq{<a href="$linkval" class="$className" title="$title">$link_text</a>};
+        my $linkval = "attachment.cgi?id=$attachid";
+        return qq{<a href="$linkval" class="$className" title="$title">$link_text</a> [<a href="$linkval&amp;action=edit">edit</a>]};
     }
     else {
         return qq{$link_text};