From: Egor Shestakov <egor@ved1.me>
Date: Wed, 18 Feb 2026 14:43:30 +0000 (+0000)
Subject: CLEANUP: mux-h1: Remove unneeded null check
X-Git-Tag: v3.4-dev5~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6ab86ca14ceab5f1bdb376053e886e31f0dc846a;p=thirdparty%2Fhaproxy.git

CLEANUP: mux-h1: Remove unneeded null check

Since 3.1 a task is always created when H1 connections initialize, so
the later null check before task_queue() became unneeded.

Could be backported with 3c09b3432 (BUG/MEDIUM: mux-h1: Fix how timeouts
are applied on H1 connections).
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index bdb461237..430ff0da1 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -1371,11 +1371,9 @@ static int h1_init(struct connection *conn, struct proxy *proxy, struct session
 			    H1_EV_H1C_NEW|H1_EV_STRM_NEW, h1c->conn, h1c->h1s);
 	}
 
-	if (t) {
-		h1_set_idle_expiration(h1c);
-		t->expire = tick_first(t->expire, h1c->idle_exp);
-		task_queue(t);
-	}
+	h1_set_idle_expiration(h1c);
+	t->expire = tick_first(t->expire, h1c->idle_exp);
+	task_queue(t);
 
 	/* prepare to read something */
 	if (b_data(&h1c->ibuf))