From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 13 Jun 2018 14:26:57 +0000 (+0300)
Subject: lib: Assert-crash if duplicate event categories are tried to be registered
X-Git-Tag: 2.3.9~1652
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6aedc3b8378a252e23c2c6db51a07baee84b0e9e;p=thirdparty%2Fdovecot%2Fcore.git

lib: Assert-crash if duplicate event categories are tried to be registered
---

diff --git a/src/lib/lib-event.c b/src/lib/lib-event.c
index b3fbabb6ea..416e6b56dd 100644
--- a/src/lib/lib-event.c
+++ b/src/lib/lib-event.c
@@ -284,6 +284,9 @@ static void event_category_register(struct event_category *category)
 	if (category->parent != NULL)
 		event_category_register(category->parent);
 
+	/* Don't allow duplicate category structs with the same name.
+	   Event filtering uses pointer comparisons for efficiency. */
+	i_assert(event_category_find_registered(category->name) == NULL);
 	category->registered = TRUE;
 	array_append(&event_registered_categories, &category, 1);