From: Mark Andrews <marka@isc.org>
Date: Thu, 14 Nov 2013 01:31:25 +0000 (+1100)
Subject: fix dereference before null check warning
X-Git-Tag: v9.6-ESV-R11b1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6aedca87839d128f2bf2015090f1375ddb9a0efd;p=thirdparty%2Fbind9.git

fix dereference before null check warning

(cherry picked from commit 980097441934ea2c87fae44520abf1600029ea93)
---

diff --git a/bin/named/lwdgrbn.c b/bin/named/lwdgrbn.c
index 057eac91c94..f31923ba2cb 100644
--- a/bin/named/lwdgrbn.c
+++ b/bin/named/lwdgrbn.c
@@ -204,6 +204,8 @@ lookup_done(isc_task_t *task, isc_event_t *event) {
 	lwres_grbnresponse_t *grbn;
 	int i;
 
+	REQUIRE(event != NULL);
+
 	UNUSED(task);
 
 	lwb.base = NULL;
@@ -384,8 +386,7 @@ lookup_done(isc_task_t *task, isc_event_t *event) {
 	if (lwb.base != NULL)
 		lwres_context_freemem(cm->lwctx, lwb.base, lwb.length);
 
-	if (event != NULL)
-		isc_event_free(&event);
+	isc_event_free(&event);
 
 	ns_lwdclient_log(50, "error constructing getrrsetbyname response");
 	ns_lwdclient_errorpktsend(client, LWRES_R_FAILURE);