From: Ralph Boehme <slow@samba.org>
Date: Fri, 10 Sep 2021 05:01:56 +0000 (+0200)
Subject: rpcclient: don't ignore unknown options
X-Git-Tag: ldb-2.5.0~717
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6afa1b3485cef59676dbccf0276bdfa289e009b4;p=thirdparty%2Fsamba.git

rpcclient: don't ignore unknown options

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c
index 7c9982b33e9..cf32229f303 100644
--- a/source3/rpcclient/rpcclient.c
+++ b/source3/rpcclient/rpcclient.c
@@ -1198,6 +1198,12 @@ out_free:
 				result = 1;
 				goto done;
 			}
+			break;
+		case POPT_ERROR_BADOPT:
+			fprintf(stderr, "\nInvalid option %s: %s\n\n",
+				poptBadOption(pc, 0), poptStrerror(opt));
+			poptPrintUsage(pc, stderr, 0);
+			exit(1);
 		}
 	}