From: André Draszik Date: Mon, 5 Jan 2026 12:34:35 +0000 (+0000) Subject: mailbox: exynos: drop unneeded runtime pointer (pclk) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b0eadf69bd1b33e887f5f089e056739921ebe42;p=thirdparty%2Fkernel%2Flinux.git mailbox: exynos: drop unneeded runtime pointer (pclk) pclk is not needed past probe(), just drop it. This saves a little bit of runtime memory. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski Reviewed-by: Tudor Ambarus Signed-off-by: Jassi Brar --- diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c index 2320649bf60c..5f2d3b81c1db 100644 --- a/drivers/mailbox/exynos-mailbox.c +++ b/drivers/mailbox/exynos-mailbox.c @@ -35,12 +35,10 @@ * struct exynos_mbox - driver's private data. * @regs: mailbox registers base address. * @mbox: pointer to the mailbox controller. - * @pclk: pointer to the mailbox peripheral clock. */ struct exynos_mbox { void __iomem *regs; struct mbox_controller *mbox; - struct clk *pclk; }; static int exynos_mbox_send_data(struct mbox_chan *chan, void *data) @@ -100,6 +98,7 @@ static int exynos_mbox_probe(struct platform_device *pdev) struct exynos_mbox *exynos_mbox; struct mbox_controller *mbox; struct mbox_chan *chans; + struct clk *pclk; int i; exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL); @@ -119,9 +118,9 @@ static int exynos_mbox_probe(struct platform_device *pdev) if (IS_ERR(exynos_mbox->regs)) return PTR_ERR(exynos_mbox->regs); - exynos_mbox->pclk = devm_clk_get_enabled(dev, "pclk"); - if (IS_ERR(exynos_mbox->pclk)) - return dev_err_probe(dev, PTR_ERR(exynos_mbox->pclk), + pclk = devm_clk_get_enabled(dev, "pclk"); + if (IS_ERR(pclk)) + return dev_err_probe(dev, PTR_ERR(pclk), "Failed to enable clock.\n"); mbox->num_chans = EXYNOS_MBOX_CHAN_COUNT;