From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 26 May 2020 03:22:48 +0000 (-0400)
Subject: Updates for examples / performance
X-Git-Tag: rel_1_4_0b1~300
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b3513f56c2a5d3ba45215b2438c47dba4336740;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Updates for examples / performance

Change-Id: I55fc60258075f6f3efb7f738b900f60b2d2994c4
---

diff --git a/doc/build/changelog/unreleased_13/perf_suite.rst b/doc/build/changelog/unreleased_13/perf_suite.rst
new file mode 100644
index 0000000000..f928cd3ed3
--- /dev/null
+++ b/doc/build/changelog/unreleased_13/perf_suite.rst
@@ -0,0 +1,7 @@
+.. change::
+    :tags: change, examples
+
+    Added new option ``--raw`` to the examples.performance suite
+    which will dump the raw profile test for consumption by any
+    number of profiling visualizer tools.   Removed the "runsnake"
+    option as runsnake is very hard to build at this point;
diff --git a/examples/performance/__init__.py b/examples/performance/__init__.py
index 28a5661066..f4f53f0d50 100644
--- a/examples/performance/__init__.py
+++ b/examples/performance/__init__.py
@@ -107,15 +107,6 @@ individual tests::
 
         ...
 
-Using RunSnake
---------------
-
-This option requires the `RunSnake <https://pypi.python.org/pypi/RunSnakeRun>`_
-command line tool be installed::
-
-    $ python -m examples.performance single_inserts --test test_core --num 1000 --runsnake
-
-A graphical RunSnake output will be displayed.
 
 .. _examples_profiling_writeyourown:
 
@@ -213,9 +204,6 @@ We can run our new script directly::
     test_joinedload : load everything, joined eager loading. (1000 iterations); total time 2.754592 sec
     test_subqueryload : load everything, subquery eager loading. (1000 iterations); total time 2.977696 sec
 
-As well as see RunSnake output for an individual test::
-
-    $ python test_loads.py  --num 100 --runsnake --test test_joinedload
 
 """  # noqa
 import argparse
@@ -238,9 +226,9 @@ class Profiler(object):
     def __init__(self, options):
         self.test = options.test
         self.dburl = options.dburl
-        self.runsnake = options.runsnake
         self.profile = options.profile
         self.dump = options.dump
+        self.raw = options.raw
         self.callers = options.callers
         self.num = options.num
         self.echo = options.echo
@@ -317,7 +305,7 @@ class Profiler(object):
     def _run_test(self, fn):
         if self._setup:
             self._setup(self.dburl, self.echo, self.num)
-        if self.profile or self.runsnake or self.dump:
+        if self.profile or self.dump:
             self._run_with_profile(fn, self.sort)
         else:
             self._run_with_time(fn)
@@ -371,14 +359,14 @@ class Profiler(object):
             help="dump full call profile (implies --profile)",
         )
         parser.add_argument(
-            "--callers",
-            action="store_true",
-            help="print callers as well (implies --dump)",
+            "--raw",
+            type=str,
+            help="dump raw profile data to file (implies --profile)",
         )
         parser.add_argument(
-            "--runsnake",
+            "--callers",
             action="store_true",
-            help="invoke runsnakerun (implies --profile)",
+            help="print callers as well (implies --dump)",
         )
         parser.add_argument(
             "--echo", action="store_true", help="Echo SQL output"
@@ -386,7 +374,7 @@ class Profiler(object):
         args = parser.parse_args()
 
         args.dump = args.dump or args.callers
-        args.profile = args.profile or args.dump or args.runsnake
+        args.profile = args.profile or args.dump or args.raw
 
         if cls.name is None:
             __import__(__name__ + "." + args.name)
@@ -431,10 +419,10 @@ class TestResult(object):
         return summary
 
     def report_stats(self):
-        if self.profile.runsnake:
-            self._runsnake()
-        elif self.profile.dump:
+        if self.profile.dump:
             self._dump(self.sort)
+        elif self.profile.raw:
+            self._dump_raw()
 
     def _dump(self, sort):
         self.stats.sort_stats(*re.split(r"[ ,]", self.sort))
@@ -442,6 +430,9 @@ class TestResult(object):
         if self.profile.callers:
             self.stats.print_callers()
 
+    def _dump_raw(self):
+        self.stats.dump_stats(self.profile.raw)
+
     def _runsnake(self):
         filename = "%s.profile" % self.test.__name__
         try: