From: Leif Madsen <leif@leifmadsen.com>
Date: Mon, 17 May 2010 14:35:18 +0000 (+0000)
Subject: Manager cookies are not compatible with RFC2109.
X-Git-Tag: 1.4.33-rc1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b3e94647947fbb00bede758e843b88f318a5864;p=thirdparty%2Fasterisk.git

Manager cookies are not compatible with RFC2109.

The Version field in the cookies we're setting contain quotes around the version
number which is not compatible with RFC2109 and breaks some implementations.

(closes issue #17231)
Reported by: ecarruda
Patches:
      manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559)
      manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559)
Tested by: ecarruda, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/http.c b/main/http.c
index f8d9f1e526..213701d61f 100644
--- a/main/http.c
+++ b/main/http.c
@@ -572,7 +572,7 @@ char *ast_http_setcookie(const char *var, const char *val, int expires, char *bu
 {
 	char *c;
 	c = buf;
-	ast_build_string(&c, &buflen, "Set-Cookie: %s=\"%s\"; Version=\"1\"", var, val);
+	ast_build_string(&c, &buflen, "Set-Cookie: %s=\"%s\"; Version=1", var, val);
 	if (expires)
 		ast_build_string(&c, &buflen, "; Max-Age=%d", expires);
 	ast_build_string(&c, &buflen, "\r\n");