From: Roy Marples <roy@marples.name>
Date: Tue, 29 Sep 2020 07:00:24 +0000 (+0100)
Subject: Add a comment to prior incase I do something dumb like removing it
X-Git-Tag: v9.3.0~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b5a6be3a2f1532abb914ae4e3ade8c8701821ec;p=thirdparty%2Fdhcpcd.git

Add a comment to prior incase I do something dumb like removing it

in the future if I forgot why it was there.
---

diff --git a/src/dhcp.c b/src/dhcp.c
index 923c5af5..623b21bc 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -3477,6 +3477,13 @@ dhcp_packet(struct interface *ifp, uint8_t *data, size_t len,
 #ifdef PRIVSEP
 	const struct dhcp_state *state = D_CSTATE(ifp);
 
+	/* It's possible that an interface departs and arrives in short
+	 * order to receive a BPF frame out of order.
+	 * There is a similar check in ARP, but much lower down the stack.
+	 * It's not needed for other inet protocols because we send the
+	 * message as a whole and select the interface off that and then
+	 * check state. BPF on the other hand is very interface
+	 * specific and we do need this check. */
 	if (state == NULL)
 		return;