From: John Ferlan <jferlan@redhat.com>
Date: Fri, 14 Apr 2017 13:24:33 +0000 (-0400)
Subject: test: Remove unnecessary unlocks in cleanup paths
X-Git-Tag: v3.3.0-rc1~93
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b5ac3c71d8472f7e4d5c45ada31ae53a157af03;p=thirdparty%2Flibvirt.git

test: Remove unnecessary unlocks in cleanup paths

Commit id '865f479da' altered the logic to use a common test*ObjFindByName
helpers which would lock/unlock the test driver; however, a few cleanup paths
in that cleanup missed removing the Unlock, so remove it now.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 00999b1161..2db3f7ddfe 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3931,7 +3931,6 @@ testInterfaceUndefine(virInterfacePtr iface)
     ret = 0;
 
  cleanup:
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -3960,7 +3959,6 @@ testInterfaceCreate(virInterfacePtr iface,
  cleanup:
     if (privinterface)
         virInterfaceObjUnlock(privinterface);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -3989,7 +3987,6 @@ testInterfaceDestroy(virInterfacePtr iface,
  cleanup:
     if (privinterface)
         virInterfaceObjUnlock(privinterface);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -4480,7 +4477,6 @@ testStoragePoolUndefine(virStoragePoolPtr pool)
     if (privpool)
         virStoragePoolObjUnlock(privpool);
     testObjectEventQueue(privconn, event);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -4591,7 +4587,6 @@ testStoragePoolDestroy(virStoragePoolPtr pool)
     testObjectEventQueue(privconn, event);
     if (privpool)
         virStoragePoolObjUnlock(privpool);
-    testDriverUnlock(privconn);
     return ret;
 }