From: Volker Lendecke <vl@samba.org>
Date: Wed, 15 Jul 2026 11:00:27 +0000 (+0200)
Subject: rpc_server: Simplify dcesrv_samr_GetAliasMembership()
X-Git-Tag: samba-4.25.0rc1~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b7c4640550cce8c2f231ea256e5cc3b2f0a49c4;p=thirdparty%2Fsamba.git

rpc_server: Simplify dcesrv_samr_GetAliasMembership()

Use talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index e756422be4f..2fb24d95802 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -2060,21 +2060,16 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
 				 "(objectclass=group)(|",
 				 GTYPE_SECURITY_BUILTIN_LOCAL_GROUP,
 				 GTYPE_SECURITY_DOMAIN_LOCAL_GROUP);
-	if (filter == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
-
 	for (i=0; i<r->in.sids->num_sids; i++) {
 		struct dom_sid_buf buf;
 
-		filter = talloc_asprintf_append(
-			filter,
+		talloc_asprintf_addbuf(
+			&filter,
 			"(member=<SID=%s>)",
 			dom_sid_str_buf(r->in.sids->sids[i].sid, &buf));
-
-		if (filter == NULL) {
-			return NT_STATUS_NO_MEMORY;
-		}
+	}
+	if (filter == NULL) {
+		return NT_STATUS_NO_MEMORY;
 	}
 
 	/* Find out if we had at least one valid member SID passed - otherwise