From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 12 Mar 2021 09:12:51 +0000 (+0100)
Subject: virLockSpacePreExecRestart: Avoid use-after-free
X-Git-Tag: v7.2.0-rc1~141
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b8e961399549c5c8fdf06875e5981c564829ad6;p=thirdparty%2Flibvirt.git

virLockSpacePreExecRestart: Avoid use-after-free

Recent refactor marked 'object' which is returned from the function as
autofree but forgot to use g_steal_pointer in the return statement to
prevent freeing it.

Fixes: 9a1651f64d7
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c
index f253091f39..9e80db6a0c 100644
--- a/src/util/virlockspace.c
+++ b/src/util/virlockspace.c
@@ -472,7 +472,7 @@ virJSONValuePtr virLockSpacePreExecRestart(virLockSpacePtr lockspace)
         goto error;
 
     virMutexUnlock(&lockspace->lock);
-    return object;
+    return g_steal_pointer(&object);
 
  error:
     virMutexUnlock(&lockspace->lock);