From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 21 Mar 2025 11:41:52 +0000 (+0200)
Subject: config: Fix file descriptor leak if "set = <file" handling fails due to fstat()
X-Git-Tag: 2.4.2~882
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6b96fe9f8e48e547c5e2ad9220d645dc663b42d8;p=thirdparty%2Fdovecot%2Fcore.git

config: Fix file descriptor leak if "set = <file" handling fails due to fstat()

Broken by 0301f03cbe9123302a439756f54a713373b86c69
---

diff --git a/src/config/config-parser.c b/src/config/config-parser.c
index b97db6298c..67cbc4fbb4 100644
--- a/src/config/config-parser.c
+++ b/src/config/config-parser.c
@@ -1726,8 +1726,10 @@ str_append_file(struct config_parser_context *ctx, string_t *str,
 					   key, path);
 		return -1;
 	}
-	if (config_parser_add_seen_file_fd(ctx, fd, path, error_r) < 0)
+	if (config_parser_add_seen_file_fd(ctx, fd, path, error_r) < 0) {
+		i_close_fd(&fd);
 		return -1;
+	}
 	while ((ret = read(fd, buf, sizeof(buf))) > 0)
 		str_append_data(str, buf, ret);
 	if (ret < 0) {