From: Ondřej Surý <ondrej@sury.org>
Date: Sun, 13 Oct 2019 04:53:06 +0000 (+0200)
Subject: dnssec: don't qsort() empty hashlist
X-Git-Tag: v9.15.6~36^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bbb0b8e42cd7b2d6ffd9de8517f1a85e60c8019;p=thirdparty%2Fbind9.git

dnssec: don't qsort() empty hashlist
---

diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c
index 8f3e74cb2c8..47b7c257c07 100644
--- a/bin/dnssec/dnssec-signzone.c
+++ b/bin/dnssec/dnssec-signzone.c
@@ -787,7 +787,10 @@ hashlist_comp(const void *a, const void *b) {
 
 static void
 hashlist_sort(hashlist_t *l) {
-	qsort(l->hashbuf, l->entries, l->length, hashlist_comp);
+	INSIST(l->hashbuf != NULL || l->length == 0);
+	if (l->length > 0) {
+		qsort(l->hashbuf, l->entries, l->length, hashlist_comp);
+	}
 }
 
 static bool