From: Ulrich Drepper <drepper@redhat.com>
Date: Thu, 25 May 2006 15:52:21 +0000 (+0000)
Subject: * nis/nis_callback.c (__nis_create_callback): Always call xdr_free
X-Git-Tag: cvs/fedora-glibc-20060531T1322~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bcb494a99389d8c9b5846f8fe32dd9e791f94f7;p=thirdparty%2Fglibc.git

* nis/nis_callback.c (__nis_create_callback): Always call xdr_free

	for cleanup when cb!=NULL [Coverity CID 233].
---

diff --git a/ChangeLog b/ChangeLog
index f0555f09e77..ff66ed6e752 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-25  Ulrich Drepper  <drepper@redhat.com>
+
+	* nis/nis_callback.c (__nis_create_callback): Always call xdr_free
+	for cleanup when cb!=NULL [Coverity CID 233].
+
 2006-05-24  Ulrich Drepper  <drepper@redhat.com>
 
 	[BZ #2693]
diff --git a/nis/nis_callback.c b/nis/nis_callback.c
index 7c76f99b6b0..e0acd9683a0 100644
--- a/nis/nis_callback.c
+++ b/nis/nis_callback.c
@@ -360,8 +360,7 @@ __nis_create_callback (int (*callback) (const_nis_name, const nis_object *,
     {
       if (cb->xprt)
 	svc_destroy (cb->xprt);
-      if (cb->serv)
-	xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
+      xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
       free (cb);
     }
   if (!nomsg)